]> git.karo-electronics.de Git - linux-beck.git/commitdiff
usb: dwc2: gadget: free TX FIFO after killing requests
authorRobert Baldyga <r.baldyga@samsung.com>
Mon, 29 Aug 2016 20:39:00 +0000 (13:39 -0700)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Wed, 31 Aug 2016 07:06:06 +0000 (10:06 +0300)
As kill_all_requests() potentially flushes TX FIFO, we should should
free FIFO after calling it. Otherwise FIFO could stay unflushed properly.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Signed-off-by: John Youn <johnyoun@synopsys.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc2/gadget.c

index 94698298e8293ed41a5e1f42f62f3f71ac06f9c6..94bd19ad7f5c8699839238e6fffb7a8ad49e16f1 100644 (file)
@@ -3120,10 +3120,6 @@ static int dwc2_hsotg_ep_disable(struct usb_ep *ep)
 
        spin_lock_irqsave(&hsotg->lock, flags);
 
-       hsotg->fifo_map &= ~(1<<hs_ep->fifo_index);
-       hs_ep->fifo_index = 0;
-       hs_ep->fifo_size = 0;
-
        ctrl = dwc2_readl(hsotg->regs + epctrl_reg);
        ctrl &= ~DXEPCTL_EPENA;
        ctrl &= ~DXEPCTL_USBACTEP;
@@ -3138,6 +3134,10 @@ static int dwc2_hsotg_ep_disable(struct usb_ep *ep)
        /* terminate all requests with shutdown */
        kill_all_requests(hsotg, hs_ep, -ESHUTDOWN);
 
+       hsotg->fifo_map &= ~(1 << hs_ep->fifo_index);
+       hs_ep->fifo_index = 0;
+       hs_ep->fifo_size = 0;
+
        spin_unlock_irqrestore(&hsotg->lock, flags);
        return 0;
 }