]> git.karo-electronics.de Git - linux-beck.git/commitdiff
usb: dwc3: ep0: avoid empty-body warning
authorArnd Bergmann <arnd@arndb.de>
Wed, 16 Nov 2016 15:37:30 +0000 (16:37 +0100)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Fri, 18 Nov 2016 11:54:54 +0000 (13:54 +0200)
Building with W=1, we get a warning about harmless empty statements:

drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_handle_intf':
drivers/usb/dwc3/ep0.c:491:4: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]

Instead of adding empty braces which would introduce checkpatch.pl
warnings, we're just removing the code which doesn't do anything and
making sure we return 0 so USBCV tool is happy.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc3/ep0.c

index 2b22ea7263d860cc5ba1ff8af03da47024a26c8d..4c06646408627ce04be863c5a8db139a1d530ae3 100644 (file)
@@ -486,12 +486,13 @@ static int dwc3_ep0_handle_intf(struct dwc3 *dwc,
 
        switch (wValue) {
        case USB_INTRF_FUNC_SUSPEND:
-               if (wIndex & USB_INTRF_FUNC_SUSPEND_LP)
-                       /* XXX enable Low power suspend */
-                       ;
-               if (wIndex & USB_INTRF_FUNC_SUSPEND_RW)
-                       /* XXX enable remote wakeup */
-                       ;
+               /*
+                * REVISIT: Ideally we would enable some low power mode here,
+                * however it's unclear what we should be doing here.
+                *
+                * For now, we're not doing anything, just making sure we return
+                * 0 so USB Command Verifier tests pass without any errors.
+                */
                break;
        default:
                ret = -EINVAL;