]> git.karo-electronics.de Git - linux-beck.git/commitdiff
[media] bttv: avoid flooding the kernel log when i2c debugging is disabled
authorJohn Törnblom <john.tornblom@gmail.com>
Mon, 17 Dec 2012 11:53:54 +0000 (08:53 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 27 Dec 2012 20:24:16 +0000 (18:24 -0200)
When the bttv driver is running without i2c_debug being set, the kernel
log is being flooded with the string ">". This string is really a part of
a debug message that is logged using several substrings protected by a
conditional check.
This patch adds the same conditional check to the leaked substring.

Signed-off-by: John Törnblom <john.tornblom@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/pci/bt8xx/bttv-i2c.c

index 580c8e682392c4c5524c789c8b21a75fbbe23314..da400dbe4a105b363721936d822fe07d8b59dc65 100644 (file)
@@ -173,7 +173,7 @@ bttv_i2c_sendbytes(struct bttv *btv, const struct i2c_msg *msg, int last)
                if (i2c_debug)
                        pr_cont(" %02x", msg->buf[cnt]);
        }
-       if (!(xmit & BT878_I2C_NOSTOP))
+       if (i2c_debug && !(xmit & BT878_I2C_NOSTOP))
                pr_cont(">\n");
        return msg->len;