]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: unisys: visorbus: controlvm_respond_chipset_init add error handling
authorDavid Kershner <david.kershner@unisys.com>
Mon, 21 Nov 2016 17:15:44 +0000 (12:15 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Nov 2016 09:01:56 +0000 (10:01 +0100)
Now that visorchannel_signalinsert returns a Linux error code, we need
to convert controlvm_respond_chipset_init to return an error instead of
a void.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/visorchipset.c

index 97d40d07005ad867b3010ae6a1e29a9647bd21af..e982a46ef1ce1cd6cff6fbb6909d2da0d9d8b82f 100644 (file)
@@ -498,7 +498,7 @@ controlvm_init_response(struct controlvm_message *msg,
        }
 }
 
-static void
+static int
 controlvm_respond_chipset_init(struct controlvm_message_header *msg_hdr,
                               int response,
                               enum ultra_chipset_feature features)
@@ -507,10 +507,8 @@ controlvm_respond_chipset_init(struct controlvm_message_header *msg_hdr,
 
        controlvm_init_response(&outmsg, msg_hdr, response);
        outmsg.cmd.init_chipset.features = features;
-       if (visorchannel_signalinsert(controlvm_channel,
-                                     CONTROLVM_QUEUE_REQUEST, &outmsg)) {
-               return;
-       }
+       return visorchannel_signalinsert(controlvm_channel,
+                                        CONTROLVM_QUEUE_REQUEST, &outmsg);
 }
 
 static void