]> git.karo-electronics.de Git - linux-beck.git/commitdiff
block: IBM RamSan 70/80 error message bug fix.
authorPhilip J Kelleher <pjk1939@linux.vnet.ibm.com>
Mon, 25 Feb 2013 19:09:40 +0000 (13:09 -0600)
committerJens Axboe <axboe@kernel.dk>
Mon, 11 Mar 2013 18:53:55 +0000 (19:53 +0100)
This patch includes a simple change to the rsxx_pci_remove
function that caused error messages because traffic was halted
too early.

Signed-off-by: Philip J Kelleher <pjk1939@linux.vnet.ibm.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/rsxx/core.c

index b82ee7baf0e84b163d978be301651ea3d15556f0..cbbdff113f465f772e5da5f1e2ddd84b9ec1e5b4 100644 (file)
@@ -538,9 +538,6 @@ static void rsxx_pci_remove(struct pci_dev *dev)
        rsxx_disable_ier_and_isr(card, CR_INTR_EVENT);
        spin_unlock_irqrestore(&card->irq_lock, flags);
 
-       /* Prevent work_structs from re-queuing themselves. */
-       card->halt = 1;
-
        cancel_work_sync(&card->event_work);
 
        rsxx_destroy_dev(card);
@@ -549,6 +546,10 @@ static void rsxx_pci_remove(struct pci_dev *dev)
        spin_lock_irqsave(&card->irq_lock, flags);
        rsxx_disable_ier_and_isr(card, CR_INTR_ALL);
        spin_unlock_irqrestore(&card->irq_lock, flags);
+
+       /* Prevent work_structs from re-queuing themselves. */
+       card->halt = 1;
+
        free_irq(dev->irq, card);
 
        if (!force_legacy)