]> git.karo-electronics.de Git - linux-beck.git/commitdiff
iio: inkern: add out of range error message
authorStefan Wahren <stefan.wahren@i2se.com>
Thu, 1 Jan 2015 18:13:24 +0000 (18:13 +0000)
committerJonathan Cameron <jic23@kernel.org>
Mon, 5 Jan 2015 18:59:50 +0000 (18:59 +0000)
If the DT contains an invalid channel specifier then the probe of
iio_hwmon fails with the following message:

iio_hwmon: probe of iio_hwmon failed with error -22

So it's better to print out the relevant channel specifier in
error case to locate the problem.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/inkern.c

index 21655fd1465c48c5f7f812d35ec6f477b9e4bda7..2800b80ea990a6c03dc7cbab71b06b179aeacf22 100644 (file)
@@ -116,8 +116,11 @@ static int __of_iio_simple_xlate(struct iio_dev *indio_dev,
        if (!iiospec->args_count)
                return 0;
 
-       if (iiospec->args[0] >= indio_dev->num_channels)
+       if (iiospec->args[0] >= indio_dev->num_channels) {
+               dev_err(&indio_dev->dev, "invalid channel index %u\n",
+                       iiospec->args[0]);
                return -EINVAL;
+       }
 
        return iiospec->args[0];
 }