]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: atomisp: fix unsigned int comparison with less than zero
authorDaeseok Youn <daeseok.youn@gmail.com>
Wed, 15 Mar 2017 05:55:06 +0000 (14:55 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 Mar 2017 02:24:08 +0000 (11:24 +0900)
Fix warnings from the smatch tool

atomisp_cmd.c:2649
  atomisp_set_array_res() warn:
  unsigned 'config->width' is never less than zero.

atomisp_cmd.c:2650
  atomisp_set_array_res() warn:
  unsigned 'config->height' is never less than zero.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c

index 1ee99d0e43ee116dd0adc01da5ed312889d72292..9c3ba11c408fb6f6ecccc1cabbcc7dff43ca00b9 100644 (file)
@@ -2646,8 +2646,7 @@ int atomisp_set_array_res(struct atomisp_sub_device *asd,
                         struct atomisp_resolution  *config)
 {
        dev_dbg(asd->isp->dev, ">%s start\n", __func__);
-       if (config == NULL || config->width < 0
-               || config->height < 0) {
+       if (!config) {
                dev_err(asd->isp->dev, "Set sensor array size is not valid\n");
                return -EINVAL;
        }