]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
[IPV6]: ipv6_fl_socklist is inadvertently shared.
authorMasayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>
Tue, 20 Mar 2007 22:23:13 +0000 (23:23 +0100)
committerAdrian Bunk <bunk@stusta.de>
Tue, 20 Mar 2007 22:23:13 +0000 (23:23 +0100)
The ipv6_fl_socklist from listening socket is inadvertently shared
with new socket created for connection.  This leads to a variety of
interesting, but fatal, bugs. For example, removing one of the
sockets may lead to the other socket's encountering a page fault
when the now freed list is referenced.

The fix is to not share the flow label list with the new socket.

Signed-off-by: Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
net/ipv6/tcp_ipv6.c

index ca9cf6853755fc3081693334c6f8f3e70265dcac..bbcb81eb1bc61d25b6495620a6ba2f5b28005f42 100644 (file)
@@ -953,6 +953,7 @@ static struct sock * tcp_v6_syn_recv_sock(struct sock *sk, struct sk_buff *skb,
           First: no IPv4 options.
         */
        newinet->opt = NULL;
+       newnp->ipv6_fl_list = NULL;
 
        /* Clone RX bits */
        newnp->rxopt.all = np->rxopt.all;