lpfc debugfs: get rid of pointless access_ok()

copy_from_user() needs no protection - it does the checks itself

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
index fce549a91911c197d8e616bce9e0c13cb17de535..ca08d3730d7b2cbbbc0ef6bee606d66e716e1b70 100644 (file)
--- a/drivers/scsi/lpfc/lpfc_debugfs.c
+++ b/drivers/scsi/lpfc/lpfc_debugfs.c
@@ -1942,10 +1942,6 @@ lpfc_debugfs_nvmestat_write(struct file *file, const char __user *buf,
        if (nbytes > 64)
                nbytes = 64;
 
-       /* Protect copy from user */
-       if (!access_ok(VERIFY_READ, buf, nbytes))
-               return -EFAULT;
-
        memset(mybuf, 0, sizeof(mybuf));
 
        if (copy_from_user(mybuf, buf, nbytes))
@@ -2026,10 +2022,6 @@ lpfc_debugfs_nvmektime_write(struct file *file, const char __user *buf,
        if (nbytes > 64)
                nbytes = 64;
 
-       /* Protect copy from user */
-       if (!access_ok(VERIFY_READ, buf, nbytes))
-               return -EFAULT;
-
        memset(mybuf, 0, sizeof(mybuf));
 
        if (copy_from_user(mybuf, buf, nbytes))
@@ -2158,10 +2150,6 @@ lpfc_debugfs_nvmeio_trc_write(struct file *file, const char __user *buf,
        if (nbytes > 64)
                nbytes = 64;
 
-       /* Protect copy from user */
-       if (!access_ok(VERIFY_READ, buf, nbytes))
-               return -EFAULT;
-
        memset(mybuf, 0, sizeof(mybuf));
 
        if (copy_from_user(mybuf, buf, nbytes))
@@ -2269,10 +2257,6 @@ lpfc_debugfs_cpucheck_write(struct file *file, const char __user *buf,
        if (nbytes > 64)
                nbytes = 64;
 
-       /* Protect copy from user */
-       if (!access_ok(VERIFY_READ, buf, nbytes))
-               return -EFAULT;
-
        memset(mybuf, 0, sizeof(mybuf));
 
        if (copy_from_user(mybuf, buf, nbytes))
@@ -2343,10 +2327,6 @@ static int lpfc_idiag_cmd_get(const char __user *buf, size_t nbytes,
        int i;
        size_t bsize;
 
-       /* Protect copy from user */
-       if (!access_ok(VERIFY_READ, buf, nbytes))
-               return -EFAULT;
-
        memset(mybuf, 0, sizeof(mybuf));
        memset(idiag_cmd, 0, sizeof(*idiag_cmd));
        bsize = min(nbytes, (sizeof(mybuf)-1));