]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
irqchip/mbigen: Fix return value check in mbigen_device_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 27 Apr 2017 15:21:13 +0000 (15:21 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 30 Apr 2017 09:21:16 +0000 (11:21 +0200)
In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). Use devm_ioremap_resource() instead of devm_ioremap()
to fix the IS_ERR() test issue.

Fixes: 76e1f77f9c26 ("irqchip/mbigen: Introduce mbigen_of_create_domain()")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Link: http://lkml.kernel.org/r/20170427152113.31147-1-weiyj.lk@gmail.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
drivers/irqchip/irq-mbigen.c

index 061cdb8bde8b55a7c0b5f0c7ed94b1c662f51644..d2306c821ebb594398d102433dcc66efcb2bf573 100644 (file)
@@ -337,8 +337,7 @@ static int mbigen_device_probe(struct platform_device *pdev)
        mgn_chip->pdev = pdev;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       mgn_chip->base = devm_ioremap(&pdev->dev, res->start,
-                                     resource_size(res));
+       mgn_chip->base = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(mgn_chip->base))
                return PTR_ERR(mgn_chip->base);