]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
swim: Release memory region after incorrect return/goto
authorJoe Perches <joe@perches.com>
Tue, 4 Jun 2013 18:34:35 +0000 (11:34 -0700)
committerGeert Uytterhoeven <geert@linux-m68k.org>
Sun, 16 Jun 2013 12:02:28 +0000 (14:02 +0200)
The code uses

return foo;
goto err_type;

when instead the form should have been

ret = foo;
goto err_type;

Here this causes a useful release_mem_region to be skipped.

Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Laurent Vivier <Laurent@Vivier.EU>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
drivers/block/swim.c

index 2f445b7a174e2c1dff1f9a2d1fb7438e9a242ff9..8ed6ccb748cffa996f38a4f4c5acf935f00a18c0 100644 (file)
@@ -893,7 +893,7 @@ static int swim_probe(struct platform_device *dev)
 
        swim_base = ioremap(res->start, resource_size(res));
        if (!swim_base) {
-               return -ENOMEM;
+               ret = -ENOMEM;
                goto out_release_io;
        }