]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
Revert "staging: tidspbridge: use safer test on the result of find_first_zero_bit"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Jun 2014 20:18:06 +0000 (13:18 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Jun 2014 20:18:06 +0000 (13:18 -0700)
This reverts commit cc0be81f00472d782804293766ddd9d1c2b4ebd1, it was
incorrect.

Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/tidspbridge/rmgr/node.c

index 305f3a60db71475c82096bbcd4e2c32888c617ca..9d3044a384eeb4b882cc1cd24cb8cf26e86082a8 100644 (file)
@@ -935,7 +935,7 @@ int node_connect(struct node_object *node1, u32 stream1,
                                 node2_type == NODE_DAISSOCKET)) {
                /* Find available pipe */
                pipe_id = find_first_zero_bit(hnode_mgr->pipe_map, MAXPIPES);
-               if (pipe_id >= MAXPIPES) {
+               if (pipe_id == MAXPIPES) {
                        status = -ECONNREFUSED;
                        goto out_unlock;
                }
@@ -1008,7 +1008,7 @@ int node_connect(struct node_object *node1, u32 stream1,
                        status = -EINVAL;
                        goto out_unlock;
                }
-               if (chnl_id >= CHNL_MAXCHANNELS) {
+               if (chnl_id == CHNL_MAXCHANNELS) {
                        status = -ECONNREFUSED;
                        goto out_unlock;
                }