]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
spi/spi-fsl-spi: reference correct pdata in fsl_spi_cs_control
authorHerton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
Fri, 11 May 2012 22:29:50 +0000 (15:29 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 May 2012 23:44:00 +0000 (00:44 +0100)
commit 067aa4815a9bc12a569d8a06afef50ba5773afbf upstream.

Commit 178db7d3, "spi: Fix device unregistration when unregistering
the bus master", changed spi device initialization of dev.parent pointer
to be the master's device pointer instead of his parent.

This introduced a bug in spi-fsl-spi, since its usage of spi device
pointer was not updated accordingly. This was later fixed by commit
5039a86, "spi/mpc83xx: fix NULL pdata dereference bug", but it missed
another spot on fsl_spi_cs_control function where we also need to update
usage of spi device pointer. This change address that.

Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
Acked-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/spi/spi-fsl-spi.c

index 5f748c0d96bdf5444e85408fa21b515b5873639f..6a62934ca74c13b36a01a8e06bbd28c7c275807e 100644 (file)
@@ -933,7 +933,7 @@ err:
 
 static void fsl_spi_cs_control(struct spi_device *spi, bool on)
 {
-       struct device *dev = spi->dev.parent;
+       struct device *dev = spi->dev.parent->parent;
        struct mpc8xxx_spi_probe_info *pinfo = to_of_pinfo(dev->platform_data);
        u16 cs = spi->chip_select;
        int gpio = pinfo->gpios[cs];