]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
rtc: rtc-ds1511: use devm_rtc_device_register()
authorJingoo Han <jg1.han@samsung.com>
Tue, 26 Mar 2013 23:25:23 +0000 (10:25 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 2 Apr 2013 07:29:33 +0000 (18:29 +1100)
devm_rtc_device_register() is device managed and makes cleanup
paths simpler.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/rtc/rtc-ds1511.c

index 6a3fcfe3b0e7379f88d8901a4d68b9c38c9261f9..6ce8a997cf5196720a31d8a47add57eb62bd0b8b 100644 (file)
@@ -538,15 +538,14 @@ static int ds1511_rtc_probe(struct platform_device *pdev)
                }
        }
 
-       rtc = rtc_device_register(pdev->name, &pdev->dev, &ds1511_rtc_ops,
-               THIS_MODULE);
+       rtc = devm_rtc_device_register(&pdev->dev, pdev->name, &ds1511_rtc_ops,
+                                       THIS_MODULE);
        if (IS_ERR(rtc))
                return PTR_ERR(rtc);
        pdata->rtc = rtc;
 
        ret = sysfs_create_bin_file(&pdev->dev.kobj, &ds1511_nvram_attr);
-       if (ret)
-               rtc_device_unregister(pdata->rtc);
+
        return ret;
 }
 
@@ -555,7 +554,6 @@ static int ds1511_rtc_remove(struct platform_device *pdev)
        struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
 
        sysfs_remove_bin_file(&pdev->dev.kobj, &ds1511_nvram_attr);
-       rtc_device_unregister(pdata->rtc);
        if (pdata->irq > 0) {
                /*
                 * disable the alarm interrupt