]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: comedi: drivers: remove extra parentheses around right bit shift operation
authorAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Wed, 4 Mar 2015 05:28:48 +0000 (07:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Mar 2015 23:22:41 +0000 (15:22 -0800)
Removes extra parentheses around bitwise right shift operation.
The issue was detected and resolved using the following coccinelle
script:

@@
expression e, e1;
constant c;
@@

e =
-(e1
+e1
>>
-c);
+c;

@@
identifier i;
constant c;
type t;
expression e;
@@

t i =
-(e
+e
>>
-c);
+c;

@@
expression e, e1;
identifier f;
constant c;
@@

e1 = f(...,
-(e
+e
>>
-c)
+c
,...);

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/dt2801.c

index b96e60ffad73bcd58d9e3d1bec19d461a160199e..7e565fc944c4a82a6cd251a64390aa52c08a10b2 100644 (file)
@@ -280,7 +280,7 @@ static int dt2801_writedata2(struct comedi_device *dev, unsigned int data)
        ret = dt2801_writedata(dev, data & 0xff);
        if (ret < 0)
                return ret;
-       ret = dt2801_writedata(dev, (data >> 8));
+       ret = dt2801_writedata(dev, data >> 8);
        if (ret < 0)
                return ret;