]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: rtl8192u: move stats_IndicateArray off stack
authorArnd Bergmann <arnd@arndb.de>
Thu, 2 Feb 2017 14:38:24 +0000 (15:38 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Feb 2017 12:01:36 +0000 (13:01 +0100)
Putting 128 pointers on the stack is rather wasteful, in particular
on 64-bit architectures:

drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c: In function 'RxPktPendingTimeout':
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:92:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=]

The rtl8192e driver has the exact same function, except that stores the
array in its 'ieee' structure. Let's do it the same way here for consistency.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/ieee80211.h
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c

index 077ea13eb1e74a847a05a865be76ce18c6ca7b57..bc33983f015a0d63c689d5673fab40f13ad49538 100644 (file)
@@ -1894,6 +1894,7 @@ struct ieee80211_device {
        //u32 STA_EDCA_PARAM[4];
        //CHANNEL_ACCESS_SETTING ChannelAccessSetting;
 
+       struct ieee80211_rxb *stats_IndicateArray[REORDER_WIN_SIZE];
 
        /* Callback functions */
        void (*set_security)(struct net_device *dev,
index 6033502eff3d1d0faf92df22fdd504ab037eeac0..b9ff8fec2edf56a3acb56a1dc28a2438d768c313 100644 (file)
@@ -31,7 +31,6 @@ static void RxPktPendingTimeout(unsigned long data)
 
        //u32 flags = 0;
        unsigned long flags = 0;
-       struct ieee80211_rxb *stats_IndicateArray[REORDER_WIN_SIZE];
        u8 index = 0;
        bool bPktInBuf = false;
 
@@ -55,7 +54,7 @@ static void RxPktPendingTimeout(unsigned long data)
                                        pRxTs->RxIndicateSeq = (pRxTs->RxIndicateSeq + 1) % 4096;
 
                                IEEE80211_DEBUG(IEEE80211_DL_REORDER,"RxPktPendingTimeout(): IndicateSeq: %d\n", pReorderEntry->SeqNum);
-                               stats_IndicateArray[index] = pReorderEntry->prxb;
+                               ieee->stats_IndicateArray[index] = pReorderEntry->prxb;
                                index++;
 
                                list_add_tail(&pReorderEntry->List, &ieee->RxReorder_Unused_List);
@@ -79,7 +78,7 @@ static void RxPktPendingTimeout(unsigned long data)
                        spin_unlock_irqrestore(&(ieee->reorder_spinlock), flags);
                        return;
                }
-               ieee80211_indicate_packets(ieee, stats_IndicateArray, index);
+               ieee80211_indicate_packets(ieee, ieee->stats_IndicateArray, index);
        }
 
        if(bPktInBuf && (pRxTs->RxTimeoutIndicateSeq==0xffff))