]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
tracing: Improve message of empty set_graph_notrace file
authorNamhyung Kim <namhyung@kernel.org>
Thu, 12 Jun 2014 16:23:51 +0000 (01:23 +0900)
committerSteven Rostedt <rostedt@goodmis.org>
Tue, 1 Jul 2014 11:13:44 +0000 (07:13 -0400)
When there's no entry in set_graph_notrace, it'll print below message

  #### all functions enabled ####

While this is technically correct, it's better to print like below:

  #### no functions disabled ####

Link: http://lkml.kernel.org/p/1402590233-22321-3-git-send-email-namhyung@kernel.org
Reported-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/ftrace.c

index 17885a27281ca2bb32da78a0ba7a0695bc17256b..ee245c0659a6cab3d89ba2061a6d32f4b58d35ed 100644 (file)
@@ -4089,7 +4089,12 @@ static int g_show(struct seq_file *m, void *v)
                return 0;
 
        if (ptr == (unsigned long *)1) {
-               seq_printf(m, "#### all functions enabled ####\n");
+               struct ftrace_graph_data *fgd = m->private;
+
+               if (fgd->table == ftrace_graph_funcs)
+                       seq_printf(m, "#### all functions enabled ####\n");
+               else
+                       seq_printf(m, "#### no functions disabled ####\n");
                return 0;
        }