]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
serial: altera: Adopt uart_console_write()
authorDaniel Thompson <daniel.thompson@linaro.org>
Fri, 11 Jul 2014 13:00:11 +0000 (14:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Jul 2014 00:49:46 +0000 (17:49 -0700)
This driver does not currently use uart_console_write() and instead
provides is own LF to LFCR conversion in it's console_write() method.
We should use the library function instead.

Cmopile tested only (with ARCH=arm).

Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Tobias Klauser <tklauser@distanz.ch>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: linux-serial@vger.kernel.org
Cc: nios2-dev@lists.rocketboards.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/altera_uart.c

index 4c1eae93110c4b1c90e18d06e4b4a0ad005d4a8c..6a243239dbefee1f0edaf06b62c306b13881192c 100644 (file)
@@ -430,7 +430,7 @@ static struct altera_uart altera_uart_ports[CONFIG_SERIAL_ALTERA_UART_MAXPORTS];
 
 #if defined(CONFIG_SERIAL_ALTERA_UART_CONSOLE)
 
-static void altera_uart_console_putc(struct uart_port *port, const char c)
+static void altera_uart_console_putc(struct uart_port *port, int c)
 {
        while (!(altera_uart_readl(port, ALTERA_UART_STATUS_REG) &
                 ALTERA_UART_STATUS_TRDY_MSK))
@@ -444,11 +444,7 @@ static void altera_uart_console_write(struct console *co, const char *s,
 {
        struct uart_port *port = &(altera_uart_ports + co->index)->port;
 
-       for (; count; count--, s++) {
-               altera_uart_console_putc(port, *s);
-               if (*s == '\n')
-                       altera_uart_console_putc(port, '\r');
-       }
+       uart_console_write(port, s, count, altera_uart_console_putc);
 }
 
 static int __init altera_uart_console_setup(struct console *co, char *options)