]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
eeepc-laptop: fix led initialization order
authorAlan Jenkins <alan-jenkins@tuffmail.co.uk>
Thu, 3 Dec 2009 07:44:57 +0000 (07:44 +0000)
committerLen Brown <len.brown@intel.com>
Wed, 9 Dec 2009 20:54:31 +0000 (15:54 -0500)
Create the workqueue thread used by tpd_led_set() *before* we register
the led device.  (And vice versa for unregistration).

Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/platform/x86/eeepc-laptop.c

index 6c982d6c3a542f849dc5b620599040f4c5030e6c..ac45fafbb796a660d2568dd5f865022814684de1 100644 (file)
@@ -1074,10 +1074,10 @@ static void eeepc_hwmon_exit(void)
 
 static void eeepc_led_exit(void)
 {
-       if (led_workqueue)
-               destroy_workqueue(led_workqueue);
        if (tpd_led.dev)
                led_classdev_unregister(&tpd_led);
+       if (led_workqueue)
+               destroy_workqueue(led_workqueue);
 }
 
 static int eeepc_new_rfkill(struct rfkill **rfkill,
@@ -1243,14 +1243,14 @@ static int eeepc_led_init(struct device *dev)
        if (get_acpi(CM_ASL_TPD) == -ENODEV)
                return 0;
 
-       rv = led_classdev_register(dev, &tpd_led);
-       if (rv)
-               return rv;
-
        led_workqueue = create_singlethread_workqueue("led_workqueue");
        if (!led_workqueue)
                return -ENOMEM;
 
+       rv = led_classdev_register(dev, &tpd_led);
+       if (rv)
+               return rv;
+
        return 0;
 }