]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
[media] lirc_dev: remove unused set_use_inc/set_use_dec
authorDavid Härdeman <david@hardeman.nu>
Mon, 1 May 2017 16:03:46 +0000 (13:03 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 6 Jun 2017 12:00:11 +0000 (09:00 -0300)
Since there are no users of this functionality, it can be removed
altogether.

Signed-off-by: David Härdeman <david@hardeman.nu>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/rc/ir-lirc-codec.c
drivers/media/rc/lirc_dev.c
include/media/lirc_dev.h

index fc58745b26b853ab1efedd4243c16f7d704b8f0a..a30af91710fe675183b8fa5dc915bc2e3181b308 100644 (file)
@@ -386,8 +386,6 @@ static int ir_lirc_register(struct rc_dev *dev)
        drv->features = features;
        drv->data = &dev->raw->lirc;
        drv->rbuf = NULL;
-       drv->set_use_inc = NULL;
-       drv->set_use_dec = NULL;
        drv->code_length = sizeof(struct ir_raw_event) * 8;
        drv->chunk_size = sizeof(int);
        drv->buffer_size = LIRCBUF_SIZE;
index 42704552b005e213056411eeb0c39128f328ee5d..05f600bd6c67e9469f9a9cb43b03320d2431646e 100644 (file)
@@ -418,12 +418,6 @@ int lirc_unregister_driver(int minor)
                wake_up_interruptible(&ir->buf->wait_poll);
        }
 
-       mutex_lock(&ir->irctl_lock);
-
-       if (ir->d.set_use_dec)
-               ir->d.set_use_dec(ir->d.data);
-
-       mutex_unlock(&ir->irctl_lock);
        mutex_unlock(&lirc_dev_lock);
 
        device_del(&ir->dev);
@@ -473,17 +467,13 @@ int lirc_dev_fop_open(struct inode *inode, struct file *file)
                        goto error;
        }
 
+       if (ir->buf)
+               lirc_buffer_clear(ir->buf);
+
+       if (ir->task)
+               wake_up_process(ir->task);
+
        ir->open++;
-       if (ir->d.set_use_inc)
-               retval = ir->d.set_use_inc(ir->d.data);
-       if (retval) {
-               ir->open--;
-       } else {
-               if (ir->buf)
-                       lirc_buffer_clear(ir->buf);
-               if (ir->task)
-                       wake_up_process(ir->task);
-       }
 
 error:
        nonseekable_open(inode, file);
@@ -508,8 +498,6 @@ int lirc_dev_fop_close(struct inode *inode, struct file *file)
        rc_close(ir->d.rdev);
 
        ir->open--;
-       if (ir->d.set_use_dec)
-               ir->d.set_use_dec(ir->d.data);
        if (!ret)
                mutex_unlock(&lirc_dev_lock);
 
index cec7d35602d1cb573c8888738fdbf2f776e74ee5..71c1c11950fe96311388b0d3bea0cdaff851559b 100644 (file)
@@ -165,10 +165,6 @@ static inline unsigned int lirc_buffer_write(struct lirc_buffer *buf,
  *                     have to write to the buffer by other means, like irq's
  *                     (see also lirc_serial.c).
  *
- * @set_use_inc:       set_use_inc will be called after device is opened
- *
- * @set_use_dec:       set_use_dec will be called after device is closed
- *
  * @rdev:              Pointed to struct rc_dev associated with the LIRC
  *                     device.
  *
@@ -198,8 +194,6 @@ struct lirc_driver {
        int max_timeout;
        int (*add_to_buf)(void *data, struct lirc_buffer *buf);
        struct lirc_buffer *rbuf;
-       int (*set_use_inc)(void *data);
-       void (*set_use_dec)(void *data);
        struct rc_dev *rdev;
        const struct file_operations *fops;
        struct device *dev;