]> git.karo-electronics.de Git - linux-beck.git/commitdiff
simplefb: Remove impossible check for of_clk_get_parent_count() < 0
authorStephen Boyd <sboyd@codeaurora.org>
Mon, 22 Feb 2016 19:14:25 +0000 (11:14 -0800)
committerStephen Boyd <sboyd@codeaurora.org>
Sat, 27 Feb 2016 00:01:32 +0000 (16:01 -0800)
The check for < 0 is impossible now that
of_clk_get_parent_count() returns an unsigned int. Simplify the
code and update the types.

Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: <linux-fbdev@vger.kernel.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/video/fbdev/simplefb.c

index 48ccf6db62a2476cac273628605ab0a4a124f709..e9cf1997728516b8cab6a1cfd67925151ee3e7c9 100644 (file)
@@ -174,7 +174,7 @@ static int simplefb_parse_pd(struct platform_device *pdev,
 struct simplefb_par {
        u32 palette[PSEUDO_PALETTE_SIZE];
 #if defined CONFIG_OF && defined CONFIG_COMMON_CLK
-       int clk_count;
+       unsigned int clk_count;
        struct clk **clks;
 #endif
 #if defined CONFIG_OF && defined CONFIG_REGULATOR
@@ -213,7 +213,7 @@ static int simplefb_clocks_init(struct simplefb_par *par,
                return 0;
 
        par->clk_count = of_clk_get_parent_count(np);
-       if (par->clk_count <= 0)
+       if (!par->clk_count)
                return 0;
 
        par->clks = kcalloc(par->clk_count, sizeof(struct clk *), GFP_KERNEL);