]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
tty: keyboard.c: Remove locking from vt_get_leds.
authorChristopher Brannon <chris@the-brannons.com>
Fri, 22 Jun 2012 13:16:34 +0000 (08:16 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 7 Oct 2012 15:35:51 +0000 (08:35 -0700)
commit 157a4b311c45c9aba75a990464d9680867dc8805 upstream.

There are three call sites for this function, and all three
are called within a keyboard handler.
kbd_event_lock is already held within keyboard handlers,
so attempting to lock it in vt_get_leds causes deadlock.

Signed-off-by: Christopher Brannon <chris@the-brannons.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/vt/keyboard.c

index 48cc6f25cfd39c319cea40e5d70232ca39c3c964..770a8544d53a22958583e550d05bf73edf581c25 100644 (file)
@@ -1049,13 +1049,10 @@ static int kbd_update_leds_helper(struct input_handle *handle, void *data)
  */
 int vt_get_leds(int console, int flag)
 {
-       unsigned long flags;
        struct kbd_struct * kbd = kbd_table + console;
        int ret;
 
-       spin_lock_irqsave(&kbd_event_lock, flags);
        ret = vc_kbd_led(kbd, flag);
-       spin_unlock_irqrestore(&kbd_event_lock, flags);
 
        return ret;
 }