]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
regmap: mmio: Fix regmap_mmio_write for uneven counts
authorPhilipp Zabel <p.zabel@pengutronix.de>
Fri, 16 May 2014 14:25:34 +0000 (16:25 +0200)
committerMark Brown <broonie@linaro.org>
Mon, 26 May 2014 15:56:02 +0000 (16:56 +0100)
Commit 932580409a9dacbf42215fa737bf06ae2c0aa624
"regmap: mmio: Add support for 1/2/8 bytes wide register address."
broke regmap_mmio_write for uneven counts, for example 32-bit register
addresses with no padding and 8-byte values (count = 5).
Fix this by allowing all counts large enough to include some value.
This check was BUG_ON(count < 4) before the last change.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/base/regmap/regmap-mmio.c

index 1e03e7f8bacb220a47d0edf29700f6a1814fc21e..902c4fb5c760b2fd589618f6d2c68a3ae54ffe4e 100644 (file)
@@ -61,9 +61,9 @@ static int regmap_mmio_regbits_check(size_t reg_bits)
        }
 }
 
-static inline void regmap_mmio_count_check(size_t count)
+static inline void regmap_mmio_count_check(size_t count, u32 offset)
 {
-       BUG_ON(count % 2 != 0);
+       BUG_ON(count <= offset);
 }
 
 static int regmap_mmio_gather_write(void *context,
@@ -120,7 +120,7 @@ static int regmap_mmio_write(void *context, const void *data, size_t count)
        struct regmap_mmio_context *ctx = context;
        u32 offset = ctx->reg_bytes + ctx->pad_bytes;
 
-       regmap_mmio_count_check(count);
+       regmap_mmio_count_check(count, offset);
 
        return regmap_mmio_gather_write(context, data, ctx->reg_bytes,
                                        data + offset, count - offset);