]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
Input: i8042 - add dbg msg when a command can't write its parameter
authorMarcos Paulo de Souza <marcos.souza.org@gmail.com>
Sun, 22 Jan 2017 22:29:22 +0000 (14:29 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Sun, 22 Jan 2017 22:32:35 +0000 (14:32 -0800)
This can happen in cases like bug #102951[1], so add a proper debug msg
as done in wait_read. Also, change wait_read debug message to differ from
wait_write.

[1] https://bugzilla.kernel.org/show_bug.cgi?id=102951

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/serio/i8042.c

index 62685a76891363b93d1d6a1d4db613fad814686b..c52da651269b094647aee0bfd63812940d06bc24 100644 (file)
@@ -312,8 +312,10 @@ static int __i8042_command(unsigned char *param, int command)
 
        for (i = 0; i < ((command >> 12) & 0xf); i++) {
                error = i8042_wait_write();
-               if (error)
+               if (error) {
+                       dbg("     -- i8042 (wait write timeout)\n");
                        return error;
+               }
                dbg("%02x -> i8042 (parameter)\n", param[i]);
                i8042_write_data(param[i]);
        }
@@ -321,7 +323,7 @@ static int __i8042_command(unsigned char *param, int command)
        for (i = 0; i < ((command >> 8) & 0xf); i++) {
                error = i8042_wait_read();
                if (error) {
-                       dbg("     -- i8042 (timeout)\n");
+                       dbg("     -- i8042 (wait read timeout)\n");
                        return error;
                }