]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
modpost: Fix resource leak in read_dump()
authorChristian Engelmayer <cengelma@gmx.at>
Mon, 28 Apr 2014 02:04:32 +0000 (11:34 +0930)
committerRusty Russell <rusty@rustcorp.com.au>
Mon, 28 Apr 2014 02:18:34 +0000 (11:48 +0930)
Function read_dump() memory maps the input via grab_file(), but fails to call
the corresponding unmap function. Add the missing call to release_file().
Detected by Coverity: CID 1192419

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
scripts/mod/modpost.c

index 066355673930342a1b5e839950cbd1186ed6c24b..ea3e2bdf1825dcdc88e2237842e2b5f5ca99decf 100644 (file)
@@ -2113,8 +2113,10 @@ static void read_dump(const char *fname, unsigned int kernel)
                s->preloaded = 1;
                sym_update_crc(symname, mod, crc, export_no(export));
        }
+       release_file(file, size);
        return;
 fail:
+       release_file(file, size);
        fatal("parse error in symbol dump file\n");
 }