]> git.karo-electronics.de Git - linux-beck.git/commitdiff
dmaengine: at_hdmac: remove channel status testing in tasklet
authorNicolas Ferre <nicolas.ferre@atmel.com>
Sat, 30 Apr 2011 14:57:48 +0000 (16:57 +0200)
committerVinod Koul <vinod.koul@intel.com>
Mon, 2 May 2011 10:12:09 +0000 (15:42 +0530)
There is no need to test if channel is enabled in tasklet:
- in error path, channel is disabled in interrupt routine
- in normal path, this test is performed in sub functions to report
a misuse of the engine.

Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/at_hdmac.c

index 8f50a0fb79e7b5e646f4596a7bc8b9ac10a21871..65bd52a84bc30b480dee796dbd5d32f663b2b171 100644 (file)
@@ -472,13 +472,6 @@ static void atc_tasklet(unsigned long data)
 {
        struct at_dma_chan *atchan = (struct at_dma_chan *)data;
 
-       /* Channel cannot be enabled here */
-       if (atc_chan_is_enabled(atchan)) {
-               dev_err(chan2dev(&atchan->chan_common),
-                       "BUG: channel enabled in tasklet\n");
-               return;
-       }
-
        spin_lock(&atchan->lock);
        if (test_and_clear_bit(ATC_IS_ERROR, &atchan->status))
                atc_handle_error(atchan);