]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: comedi: comedi_buf: remove BUG_ON in comedi_buf_munge()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Thu, 10 Jan 2013 17:36:58 +0000 (10:36 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Jan 2013 00:56:00 +0000 (16:56 -0800)
The condition that would trigger this BUG_ON can never occur.

The 'munge_count' will be equal to 'buf_write_count' if all the data
in the buffer has been munged.

Or, the 'munge_count' will be less than the 'buf_write_count' if any
partial samples in the buffer were not munged.

The 'munge_count' will never be greater than the 'buf_write_count'.

Remove the unnecessary BUG_ON.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbobbi@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/comedi_buf.c

index ac5f0a91e93b16ced3ad87f19375368d5fdba6d7..7d516a07474bf5e39deebef7be0051ca4f3135ff 100644 (file)
@@ -245,7 +245,6 @@ static unsigned int comedi_buf_munge(struct comedi_async *async,
                }
        }
 
-       BUG_ON((int)(async->munge_count - async->buf_write_count) > 0);
        return count;
 }