]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ncr5380: Add missing break after case MESSAGE_REJECT
authorFinn Thain <fthain@telegraphics.com.au>
Sun, 3 Jan 2016 05:05:31 +0000 (16:05 +1100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 7 Jan 2016 02:42:57 +0000 (21:42 -0500)
MESSAGE REJECT does not imply DISCONNECT: the target is about to enter
MESSAGE IN or MESSAGE OUT phase.

This bug fix comes from atari_NCR5380.c. Unfortunately it never made it
into the original NCR5380.c core driver.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Tested-by: Ondrej Zary <linux@rainbow-software.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/NCR5380.c

index 9b7c67f17f4b1e8701628eb5c8029eda49fe7bac..97100a1e3f805d7555e62a3049c70e4d8f76781a 100644 (file)
@@ -1990,6 +1990,7 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance) {
                                        default:
                                                break;
                                        }
+                                       break;
                                case DISCONNECT:{
                                                /* Accept message by clearing ACK */
                                                NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE);