]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
drm/fsl-dcu: do not update when modifying irq registers
authorStefan Agner <stefan@agner.ch>
Tue, 5 Jan 2016 00:34:22 +0000 (16:34 -0800)
committerStefan Agner <stefan@agner.ch>
Wed, 9 Nov 2016 01:14:08 +0000 (17:14 -0800)
The IRQ status and mask registers are not "double buffered" according
to the reference manual. Hence, there is no extra transfer/update
write needed when modifying these registers.

Signed-off-by: Stefan Agner <stefan@agner.ch>
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c

index e04efbed1a54f89e4277186405c2b46d59604d52..cc2fde2ae5eff272c8f5e15548b61b525a54c6cc 100644 (file)
@@ -59,8 +59,6 @@ static int fsl_dcu_drm_irq_init(struct drm_device *dev)
 
        regmap_write(fsl_dev->regmap, DCU_INT_STATUS, 0);
        regmap_write(fsl_dev->regmap, DCU_INT_MASK, ~0);
-       regmap_write(fsl_dev->regmap, DCU_UPDATE_MODE,
-                    DCU_UPDATE_MODE_READREG);
 
        return ret;
 }
@@ -139,8 +137,6 @@ static irqreturn_t fsl_dcu_drm_irq(int irq, void *arg)
                drm_handle_vblank(dev, 0);
 
        regmap_write(fsl_dev->regmap, DCU_INT_STATUS, int_status);
-       regmap_write(fsl_dev->regmap, DCU_UPDATE_MODE,
-                    DCU_UPDATE_MODE_READREG);
 
        return IRQ_HANDLED;
 }