]> git.karo-electronics.de Git - linux-beck.git/commitdiff
usb: gadget: f_fs: Fix ExtCompat descriptor validation
authorVincent Pelletier <plr.vincent@gmail.com>
Thu, 15 Dec 2016 12:47:42 +0000 (12:47 +0000)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Mon, 2 Jan 2017 08:55:28 +0000 (10:55 +0200)
Reserved1 is documented as expected to be set to 0, but this test fails
when it it set to 0. Reverse the condition.

Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/function/f_fs.c

index 818f4997c1ac2081fa2f541e73fe951e76f8fdb5..e4e4376de3ee3c51b68330a5320eae5f6a58202f 100644 (file)
@@ -2252,7 +2252,7 @@ static int __ffs_data_do_os_desc(enum ffs_os_desc_type type,
 
                if (len < sizeof(*d) ||
                    d->bFirstInterfaceNumber >= ffs->interfaces_count ||
-                   !d->Reserved1)
+                   d->Reserved1)
                        return -EINVAL;
                for (i = 0; i < ARRAY_SIZE(d->Reserved2); ++i)
                        if (d->Reserved2[i])