]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: rtl8723au: os_dep: Remove uneeded return variable
authorRoberta Dobrescu <roberta.dobrescu@gmail.com>
Sun, 26 Oct 2014 21:30:08 +0000 (23:30 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Oct 2014 10:45:03 +0000 (18:45 +0800)
This patch removes uneeded return variables, using only
'return _SUCCESS' instead.
It fixes the following warning detected by coccinelle:
Unneeded variable.

It was done using the following semantic patch:

@@
identifier ret;
type T;
expression e;
@@

-T ret = e;
 ... when != ret
     when strict
-return ret;
+return e;

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723au/os_dep/os_intfs.c

index ddd0a9f1eefb87bae72f0119fe58ae00f7928c60..d00100356630033de79124fcc5265a0111476276 100644 (file)
@@ -175,7 +175,6 @@ static int netdev_close(struct net_device *pnetdev);
 static int loadparam(struct rtw_adapter *padapter,  struct net_device *pnetdev)
 {
        struct registry_priv  *registry_par = &padapter->registrypriv;
-       int status = _SUCCESS;
 
        GlobalDebugLevel23A = rtw_debug;
        registry_par->chip_version = (u8)rtw_chip_version;
@@ -234,7 +233,7 @@ static int loadparam(struct rtw_adapter *padapter,  struct net_device *pnetdev)
        snprintf(registry_par->if2name, 16, "%s", if2name);
        registry_par->notch_filter = (u8)rtw_notch_filter;
        registry_par->regulatory_tid = (u8)rtw_regulatory_id;
-       return status;
+       return _SUCCESS;
 }
 
 static int rtw_net_set_mac_address(struct net_device *pnetdev, void *p)
@@ -384,7 +383,6 @@ static int rtw_init_default_value(struct rtw_adapter *padapter)
        struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
        struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
        struct security_priv *psecuritypriv = &padapter->securitypriv;
-       int ret = _SUCCESS;
 
        /* xmit_priv */
        pxmitpriv->vcs = pregistrypriv->vcs_type;
@@ -423,7 +421,7 @@ static int rtw_init_default_value(struct rtw_adapter *padapter)
        /* misc. */
        padapter->bReadPortCancel = false;
        padapter->bWritePortCancel = false;
-       return ret;
+       return _SUCCESS;
 }
 
 int rtw_reset_drv_sw23a(struct rtw_adapter *padapter)