]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
checkpatch: update the FSF/GPL address check
authorJoe Perches <joe@perches.com>
Fri, 3 Jan 2014 03:10:18 +0000 (14:10 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Fri, 3 Jan 2014 03:10:18 +0000 (14:10 +1100)
The FSF address check is a bit too verbose looking for the GPL text.
Quiet it a bit by requiring --strict for the GPL bit.

Also make the address tests match a few uses of abbreviations for street
names and make it case insensitive.

Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
scripts/checkpatch.pl

index 7e48d131df25fd0dc55e6f128072bde431a4ab17..59be6d72d9c808d826c1c7ef52fcefaa591e898e 100755 (executable)
@@ -1970,15 +1970,16 @@ sub process {
                }
 
 # Check for FSF mailing addresses.
-               if ($rawline =~ /You should have received a copy/ ||
-                   $rawline =~ /write to the Free Software/ ||
-                   $rawline =~ /59 Temple Place/ ||
-                   $rawline =~ /51 Franklin Street/) {
+               if ($rawline =~ /\bYou should have received a copy/i ||
+                   $rawline =~ /\bwrite to the Free/i ||
+                   $rawline =~ /\b59\s+Temple\s+Pl/i ||
+                   $rawline =~ /\b51\s+Franklin\s+St/i) {
                        my $herevet = "$here\n" . cat_vet($rawline) . "\n";
                        my $msg_type = \&ERROR;
                        $msg_type = \&CHK if ($file);
+                       $msg_type = \&CHK if ($rawline =~ /\bYou should have received a copy/i);
                        &{$msg_type}("FSF_MAILING_ADDRESS",
-                               "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
+                                    "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
                }
 
 # check for Kconfig help text having a real description