]> git.karo-electronics.de Git - linux-beck.git/commitdiff
dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 7 Nov 2015 15:30:34 +0000 (16:30 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Nov 2015 18:17:32 +0000 (13:17 -0500)
The of_node_put() function tests whether its argument is NULL
and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/synopsys/dwc_eth_qos.c

index 85b3326775b821f99be5d5e3dc5a065517797852..9066d7a8483c34ed5ee1ca2a697453eb55564584 100644 (file)
@@ -2970,8 +2970,7 @@ err_out_unregister_netdev:
 err_out_clk_dis_aper:
        clk_disable_unprepare(lp->apb_pclk);
 err_out_free_netdev:
-       if (lp->phy_node)
-               of_node_put(lp->phy_node);
+       of_node_put(lp->phy_node);
        free_netdev(ndev);
        platform_set_drvdata(pdev, NULL);
        return ret;