]> git.karo-electronics.de Git - linux-beck.git/commitdiff
base/platform: Only insert MEM and IO resources
authorRicardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Tue, 26 May 2015 07:31:23 +0000 (09:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 1 Jun 2015 01:15:17 +0000 (10:15 +0900)
platform_device_del only checks the type of the resource in order to
call release_resource.

On the other hand, platform_device_add calls insert_resource for any
resource that has a parent.

Make both code branches balanced.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/platform.c

index 063f0ab152590dfeea4488d2686b8ff13b99a7bf..46a56f694cec250a28ad930b853ab8517aa2d4e5 100644 (file)
@@ -341,19 +341,23 @@ int platform_device_add(struct platform_device *pdev)
 
        for (i = 0; i < pdev->num_resources; i++) {
                struct resource *p, *r = &pdev->resource[i];
+               unsigned long type = resource_type(r);
 
                if (r->name == NULL)
                        r->name = dev_name(&pdev->dev);
 
+               if (!(type == IORESOURCE_MEM || type == IORESOURCE_IO))
+                       continue;
+
                p = r->parent;
                if (!p) {
-                       if (resource_type(r) == IORESOURCE_MEM)
+                       if (type == IORESOURCE_MEM)
                                p = &iomem_resource;
-                       else if (resource_type(r) == IORESOURCE_IO)
+                       else if (type == IORESOURCE_IO)
                                p = &ioport_resource;
                }
 
-               if (p && insert_resource(p, r)) {
+               if (insert_resource(p, r)) {
                        dev_err(&pdev->dev, "failed to claim resource %d\n", i);
                        ret = -EBUSY;
                        goto failed;