]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
tg3: don't clear stats while tg3_close
authorYueHaibing <yuehaibing@huawei.com>
Wed, 3 May 2017 07:51:32 +0000 (15:51 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 3 May 2017 13:51:25 +0000 (09:51 -0400)
Now tg3 NIC's stats will be cleared after ifdown/ifup. bond_get_stats traverse
its salves to get statistics,cumulative the increment.If a tg3 NIC is added to
bonding as a slave,ifdown/ifup will cause bonding's stats become tremendous value
(ex.1638.3 PiB) because of negative increment.

Fixes: 92feeabf3f67 ("tg3: Save stats across chip resets")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/tg3.c

index f395b951f5e77bca9a926ea3f1210bf1fcb13ded..537d571ee60171f303b52f692a83a3eecdeef358 100644 (file)
@@ -11729,10 +11729,6 @@ static int tg3_close(struct net_device *dev)
 
        tg3_stop(tp);
 
-       /* Clear stats across close / open calls */
-       memset(&tp->net_stats_prev, 0, sizeof(tp->net_stats_prev));
-       memset(&tp->estats_prev, 0, sizeof(tp->estats_prev));
-
        if (pci_device_is_present(tp->pdev)) {
                tg3_power_down_prepare(tp);