USB: serial: do not forward USB specific errors in open

Use usb_translate_errors() to map USB-specific errors to errors
appropriate for user space (ENOMEM, ENODEV and EIO) in open.

Currently almost all serial drivers simply forward error codes from the
stack (e.g. from usb_submit_urb()), but these codes often have
different meanings in user-space. Doing the mapping in usb-serial core
simplifies driver code and allows for more consistent error reporting.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index 8d5190f3d8ebaa64b1b83ebdc34a73924a1202d4..a2a0574b662a3eb172142a65f05702f3e09121ad 100644 (file)
--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -260,6 +260,10 @@ static int serial_activate(struct tty_port *tport, struct tty_struct *tty)
        else
                retval = port->serial->type->open(tty, port);
        mutex_unlock(&serial->disc_mutex);
+
+       if (retval < 0)
+               retval = usb_translate_errors(retval);
+
        return retval;
 }