]> git.karo-electronics.de Git - linux-beck.git/commitdiff
[media] pctv452e: Replace memset with eth_zero_addr
authorVaishali Thakkar <vthakkar1994@gmail.com>
Fri, 26 Jun 2015 04:34:37 +0000 (01:34 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 11 Aug 2015 15:57:01 +0000 (12:57 -0300)
Use eth_zero_addr to assign the zero address to the given address
array instead of memset when second argument is address of zero.
Note that the 6 in the third argument of memset appears to represent
an ethernet address size (ETH_ALEN).

The Coccinelle semantic patch that makes this change is as follows:

// <smpl>
@eth_zero_addr@
expression e;
@@

-memset(e,0x00,6);
+eth_zero_addr(e);
// </smpl>

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/usb/dvb-usb/pctv452e.c

index d17618fe8f5c80528bb8f6febc202449b5ad2999..ec397c4b7cc8913f5f19683ce03ad1e85e2653b0 100644 (file)
@@ -611,7 +611,7 @@ static int pctv452e_read_mac_address(struct dvb_usb_device *d, u8 mac[6])
        return 0;
 
 failed:
-       memset(mac, 0, 6);
+       eth_zero_addr(mac);
 
        return ret;
 }