]> git.karo-electronics.de Git - linux-beck.git/commitdiff
regulator: max77686: Use of_get_child_by_name
authorSachin Kamat <sachin.kamat@linaro.org>
Fri, 14 Feb 2014 11:49:47 +0000 (17:19 +0530)
committerMark Brown <broonie@linaro.org>
Fri, 14 Feb 2014 21:07:45 +0000 (21:07 +0000)
of_find_node_by_name walks the allnodes list, and can thus walk
outside of the parent node. Use of_get_child_by_name instead.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/regulator/max77686.c

index ae001ccf26f42d952bec37c2a821c250e2307b3c..0e725f6ed455e392db3fb31007e7e61a285bc5f2 100644 (file)
@@ -400,7 +400,7 @@ static int max77686_pmic_dt_parse_pdata(struct platform_device *pdev,
        unsigned int i;
 
        pmic_np = iodev->dev->of_node;
-       regulators_np = of_find_node_by_name(pmic_np, "voltage-regulators");
+       regulators_np = of_get_child_by_name(pmic_np, "voltage-regulators");
        if (!regulators_np) {
                dev_err(&pdev->dev, "could not find regulators sub-node\n");
                return -EINVAL;