]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: dgap: fix possible NULL dereference
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Thu, 10 Sep 2015 11:54:58 +0000 (17:24 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Sep 2015 01:24:57 +0000 (18:24 -0700)
The return pointer from dgap_getword() is used in strcmp() where it is
dereferenced. But dgap_getword() can return NULL.
Lets put a check there and return 0 as error.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dgap/dgap.c

index 9112dd2bf4d7757503ea1b53191d213dcbc93785..20ba258ffbdb3165ea41deb8bc476a226bee00f4 100644 (file)
@@ -349,6 +349,8 @@ static int dgap_gettok(char **in)
 
        if (strstr(dgap_cword, "board")) {
                w = dgap_getword(in);
+               if (!w)
+                       return 0;
                snprintf(dgap_cword, MAXCWORD, "%s", w);
                for (t = dgap_brdtype; t->token != 0; t++) {
                        if (!strcmp(w, t->string))