]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
perf annotate: Fix 'annotate.use_offset' config variable usage
authorNamhyung Kim <namhyung@kernel.org>
Wed, 21 Oct 2015 02:57:20 +0000 (11:57 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 22 Oct 2015 19:34:29 +0000 (16:34 -0300)
The annotate__configs should be sorted so that it can use bsearch(3).

However commit 0c4a5bcea460 ("perf annotate: Display total number of
samples with --show-total-period") added a new config item at the end.
This resulted in the 'annotate.use_offset' config variable cannot be
found and perf terminated like below:

  $ perf report
  bad config file line 6 in ~/.perfconfig

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Martin Liška <mliska@suse.cz>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Taeung Song <treeze.taeung@gmail.com>
Fixes: 0c4a5bcea460 ("perf annotate: Display total number of samples with --show-total-period")
Link: http://lkml.kernel.org/r/1445396240-3428-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/annotate.c

index bec0b62d8e3897eab0e42368bdeceacb77e8a92e..ba72e018e99ae2cca894557ebdc7a74db145b511 100644 (file)
@@ -1125,8 +1125,8 @@ static struct annotate_config {
        ANNOTATE_CFG(jump_arrows),
        ANNOTATE_CFG(show_linenr),
        ANNOTATE_CFG(show_nr_jumps),
-       ANNOTATE_CFG(use_offset),
        ANNOTATE_CFG(show_total_period),
+       ANNOTATE_CFG(use_offset),
 };
 
 #undef ANNOTATE_CFG