]> git.karo-electronics.de Git - linux-beck.git/commitdiff
[SCSI] mpt2sas: fix Integrated Raid unsynced on shutdown problem
authorKashyap, Desai <kashyap.desai@lsi.com>
Tue, 4 Jan 2011 06:10:23 +0000 (11:40 +0530)
committerJames Bottomley <James.Bottomley@suse.de>
Mon, 24 Jan 2011 15:30:29 +0000 (09:30 -0600)
Issue:
IR shutdown(sending) and IR shutdown(complete) messages not
listed in /var/log/messages when driver is removed.

The driver needs to issue a MPI2_RAID_ACTION_SYSTEM_SHUTDOWN_INITIATED
request when the driver is unloaded so the IR metadata journal is updated.
If this request is not sent, then the volume would need a "check
consistency" issued on the next bootup if the volume was roamed from one
initiator to another. The current driver supports this feature only when the
system is rebooted, however this also need to be supported if the driver is
unloaded

Fix:
To fix this issue, the driver is going
to need to call the _scsih_ir_shutdown prior to reporting
the volumes missing from the OS, hence the device handles
are still present.

Signed-off-by: Kashyap Desai <kashyap.desai@lsi.com>
Cc: stable@kernel.org
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/mpt2sas/mpt2sas_scsih.c

index db287d79bdcfb96c8a9f4d432f5c11477eada8a5..5ded3db6e316f0fc75d5ba25f3c5b55f8d596b18 100644 (file)
@@ -6665,6 +6665,7 @@ _scsih_remove(struct pci_dev *pdev)
                destroy_workqueue(wq);
 
        /* release all the volumes */
+       _scsih_ir_shutdown(ioc);
        list_for_each_entry_safe(raid_device, next, &ioc->raid_device_list,
            list) {
                if (raid_device->starget) {