]> git.karo-electronics.de Git - linux-beck.git/commitdiff
drm/cirrus: Remove unecessary NULL check in gem_free
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Sat, 5 Apr 2014 08:10:08 +0000 (10:10 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 22 Apr 2014 13:39:07 +0000 (15:39 +0200)
The ->gem_free_object never gets called with a NULL pointer, the check
is redundant. Also checking after the upcast allows compilers to elide
it anyway.

Spotted by coverity.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/cirrus/cirrus_main.c

index b119f66fed924931c0fb03de3dfd252e2e410f7f..99c1983f99d228b77ce9c498236ad68b348440e2 100644 (file)
@@ -271,8 +271,6 @@ void cirrus_gem_free_object(struct drm_gem_object *obj)
 {
        struct cirrus_bo *cirrus_bo = gem_to_cirrus_bo(obj);
 
-       if (!cirrus_bo)
-               return;
        cirrus_bo_unref(&cirrus_bo);
 }