]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
printk/tracing: rework console tracing
authorzhangwei(Jovi) <jovi.zhangwei@huawei.com>
Wed, 20 Mar 2013 04:07:33 +0000 (15:07 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 20 Mar 2013 04:22:54 +0000 (15:22 +1100)
commit 7ff9554bb ("printk: convert byte-buffer to variable-length record
buffer") removed start and end parameters in call_console_drivers, but
those parameters still exists in include/trace/events/printk.h.

Without start and end parameters handling, printk tracing became more
simple as: trace_console(text, len);

Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Kay Sievers <kay@vrfy.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/trace/events/printk.h
kernel/printk.c

index 94ec79cc011ae76bd77f5f2adb40ff09343f1cdb..c008bc99f9fa9093beb2668f2ebb33a72b825715 100644 (file)
@@ -6,31 +6,18 @@
 
 #include <linux/tracepoint.h>
 
-TRACE_EVENT_CONDITION(console,
-       TP_PROTO(const char *log_buf, unsigned start, unsigned end,
-                unsigned log_buf_len),
+TRACE_EVENT(console,
+       TP_PROTO(const char *text, size_t len),
 
-       TP_ARGS(log_buf, start, end, log_buf_len),
-
-       TP_CONDITION(start != end),
+       TP_ARGS(text, len),
 
        TP_STRUCT__entry(
-               __dynamic_array(char, msg, end - start + 1)
+               __dynamic_array(char, msg, len + 1)
        ),
 
        TP_fast_assign(
-               if ((start & (log_buf_len - 1)) > (end & (log_buf_len - 1))) {
-                       memcpy(__get_dynamic_array(msg),
-                              log_buf + (start & (log_buf_len - 1)),
-                              log_buf_len - (start & (log_buf_len - 1)));
-                       memcpy((char *)__get_dynamic_array(msg) +
-                              log_buf_len - (start & (log_buf_len - 1)),
-                              log_buf, end & (log_buf_len - 1));
-               } else
-                       memcpy(__get_dynamic_array(msg),
-                              log_buf + (start & (log_buf_len - 1)),
-                              end - start);
-               ((char *)__get_dynamic_array(msg))[end - start] = 0;
+               memcpy(__get_dynamic_array(msg), text, len);
+               ((char *)__get_dynamic_array(msg))[len] = 0;
        ),
 
        TP_printk("%s", __get_str(msg))
index 78cc484cd1d43227ef502dc8f42061dbcc958ef1..d8266a5483412941240a49fcab67447cb1eab01e 100644 (file)
@@ -1268,7 +1268,7 @@ static void call_console_drivers(int level, const char *text, size_t len)
 {
        struct console *con;
 
-       trace_console(text, 0, len, len);
+       trace_console(text, len);
 
        if (!console_drivers)
                return;