]> git.karo-electronics.de Git - linux-beck.git/commitdiff
ext4: Use rcu_barrier() on module unload.
authorJesper Dangaard Brouer <hawk@comx.dk>
Mon, 6 Jul 2009 02:29:27 +0000 (22:29 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 6 Jul 2009 02:29:27 +0000 (22:29 -0400)
The ext4 module uses rcu_call() thus it should use rcu_barrier()on
module unload.

The kmem cache ext4_pspace_cachep is sometimes free'ed using
call_rcu() callbacks.  Thus, we must wait for completion of call_rcu()
before doing kmem_cache_destroy().

Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/mballoc.c

index 4a45efabb203f356662d6ffdcab7e871c0cbbace..2fcaf286f1de3b778b1df53a1bf168ae400908db 100644 (file)
@@ -2909,7 +2909,11 @@ int __init init_ext4_mballoc(void)
 
 void exit_ext4_mballoc(void)
 {
-       /* XXX: synchronize_rcu(); */
+       /* 
+        * Wait for completion of call_rcu()'s on ext4_pspace_cachep
+        * before destroying the slab cache.
+        */
+       rcu_barrier();
        kmem_cache_destroy(ext4_pspace_cachep);
        kmem_cache_destroy(ext4_ac_cachep);
        kmem_cache_destroy(ext4_free_ext_cachep);