]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
greybus: don't assume PAGE_SIZE for URB size
authorAlex Elder <elder@linaro.org>
Wed, 12 Nov 2014 21:17:50 +0000 (15:17 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Nov 2014 21:11:35 +0000 (13:11 -0800)
The buffers allocated for CPort URBS are ES1_GBUF_MSG_SIZE bytes.
But usb_fill_bulk_urb() passes PAGE_SIZE as its size.  They happen
to be the same, but the code is wrong, so fix it.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/es1-ap-usb.c

index 645edbda11d0b6214ce3213961b8aaf3077ac5a7..f82f665261b2288b27c45b3806abf643119c504d 100644 (file)
@@ -546,7 +546,8 @@ static int ap_probe(struct usb_interface *interface,
 
                usb_fill_bulk_urb(urb, udev,
                                  usb_rcvbulkpipe(udev, es1->cport_in_endpoint),
-                                 buffer, PAGE_SIZE, cport_in_callback, es1);
+                                 buffer, ES1_GBUF_MSG_SIZE, cport_in_callback,
+                                 es1);
                es1->cport_in_urb[i] = urb;
                es1->cport_in_buffer[i] = buffer;
                retval = usb_submit_urb(urb, GFP_KERNEL);