]> git.karo-electronics.de Git - linux-beck.git/commitdiff
[media] ivtv: fix sparse warnings
authorHans Verkuil <hans.verkuil@cisco.com>
Thu, 21 Aug 2014 19:31:51 +0000 (16:31 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Wed, 3 Sep 2014 13:34:13 +0000 (10:34 -0300)
drivers/media/pci/ivtv/ivtv-irq.c:195:25: warning: incorrect type in argument 1 (different base types)
drivers/media/pci/ivtv/ivtv-irq.c:199:25: warning: incorrect type in argument 1 (different base types)
drivers/media/pci/ivtv/ivtv-irq.c:278:35: warning: restricted __le32 degrades to integer
drivers/media/pci/ivtv/ivtv-irq.c:281:51: warning: restricted __le32 degrades to integer

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/pci/ivtv/ivtv-irq.c

index 19a7c9b990a393b93adb27818d069560f1027bda..ab6d5d25aa6fdd1a757814c18318dc5881e47a41 100644 (file)
@@ -192,11 +192,11 @@ static int stream_enc_dma_append(struct ivtv_stream *s, u32 data[CX2341X_MBOX_MA
                if (itv->has_cx23415 && (s->type == IVTV_ENC_STREAM_TYPE_PCM ||
                    s->type == IVTV_DEC_STREAM_TYPE_VBI)) {
                        s->pending_backup = read_dec(offset - IVTV_DECODER_OFFSET);
-                       write_dec_sync(cpu_to_le32(DMA_MAGIC_COOKIE), offset - IVTV_DECODER_OFFSET);
+                       write_dec_sync(DMA_MAGIC_COOKIE, offset - IVTV_DECODER_OFFSET);
                }
                else {
                        s->pending_backup = read_enc(offset);
-                       write_enc_sync(cpu_to_le32(DMA_MAGIC_COOKIE), offset);
+                       write_enc_sync(DMA_MAGIC_COOKIE, offset);
                }
                s->pending_offset = offset;
        }
@@ -275,13 +275,11 @@ static void dma_post(struct ivtv_stream *s)
 
                if (x == 0 && ivtv_use_dma(s)) {
                        offset = s->dma_last_offset;
-                       if (u32buf[offset / 4] != DMA_MAGIC_COOKIE)
+                       if (le32_to_cpu(u32buf[offset / 4]) != DMA_MAGIC_COOKIE)
                        {
-                               for (offset = 0; offset < 64; offset++) {
-                                       if (u32buf[offset] == DMA_MAGIC_COOKIE) {
+                               for (offset = 0; offset < 64; offset++)
+                                       if (le32_to_cpu(u32buf[offset]) == DMA_MAGIC_COOKIE)
                                                break;
-                                       }
-                               }
                                offset *= 4;
                                if (offset == 256) {
                                        IVTV_DEBUG_WARN("%s: Couldn't find start of buffer within the first 256 bytes\n", s->name);