]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
Staging: comedi: fix printk issue in pcl818.c
authorRavishankar karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Sat, 19 Nov 2011 04:36:57 +0000 (10:06 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sun, 27 Nov 2011 02:50:46 +0000 (18:50 -0800)
This is a patch to the pcl818.c file that fixes up a printk
warning found by the checkpatch.pl tool.
Removed an unnecessary printks.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/comedi/drivers/pcl818.c

index bad7ee409ed4d02478475d805ad4c2f9831c223f..7344a53a81c4daf549fe683605070ad439a83bc1 100644 (file)
@@ -1841,34 +1841,26 @@ no_rtc:
                if (dma < 1)
                        goto no_dma;    /* DMA disabled */
                if (((1 << dma) & this_board->DMAbits) == 0) {
-                       printk(", DMA is out of allowed range, FAIL!\n");
+                       printk(KERN_ERR "DMA is out of allowed range, FAIL!\n");
                        return -EINVAL; /* Bad DMA */
                }
                ret = request_dma(dma, "pcl818");
-               if (ret) {
-                       printk(", unable to allocate DMA %u, FAIL!\n", dma);
+               if (ret)
                        return -EBUSY;  /* DMA isn't free */
-               }
                devpriv->dma = dma;
-               printk(", dma=%u", dma);
                pages = 2;      /* we need 16KB */
                devpriv->dmabuf[0] = __get_dma_pages(GFP_KERNEL, pages);
-               if (!devpriv->dmabuf[0]) {
-                       printk(", unable to allocate DMA buffer, FAIL!\n");
+               if (!devpriv->dmabuf[0])
                        /* maybe experiment with try_to_free_pages() will help .... */
                        return -EBUSY;  /* no buffer :-( */
-               }
                devpriv->dmapages[0] = pages;
                devpriv->hwdmaptr[0] = virt_to_bus((void *)devpriv->dmabuf[0]);
                devpriv->hwdmasize[0] = (1 << pages) * PAGE_SIZE;
                /* printk("%d %d %ld, ",devpriv->dmapages[0],devpriv->hwdmasize[0],PAGE_SIZE); */
                if (devpriv->dma_rtc == 0) {    /*  we must do duble buff :-( */
                        devpriv->dmabuf[1] = __get_dma_pages(GFP_KERNEL, pages);
-                       if (!devpriv->dmabuf[1]) {
-                               printk
-                                   (", unable to allocate DMA buffer, FAIL!\n");
+                       if (!devpriv->dmabuf[1])
                                return -EBUSY;
-                       }
                        devpriv->dmapages[1] = pages;
                        devpriv->hwdmaptr[1] =
                            virt_to_bus((void *)devpriv->dmabuf[1]);