]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: iio: adc: ad7280a: fix permission coding style issue
authorOlivier Leveque <o_leveque@orange.fr>
Thu, 23 Mar 2017 13:18:09 +0000 (14:18 +0100)
committerJonathan Cameron <jic23@kernel.org>
Sat, 25 Mar 2017 17:07:24 +0000 (17:07 +0000)
Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. Consider using
octal permissions '0644'. Found running checkpatch.

Signed-off-by: Olivier Leveque <o_leveque@orange.fr>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/staging/iio/adc/ad7280a.c

index 6a85e284c8a424955dc8d3b77eeabcb975dbbea5..d5ab83f0236dd31131ed8b2fe20c8ff9875dfc03 100644 (file)
@@ -560,7 +560,7 @@ static int ad7280_attr_init(struct ad7280_state *st)
                        st->iio_attr[cnt].address =
                                AD7280A_DEVADDR(dev) << 8 | ch;
                        st->iio_attr[cnt].dev_attr.attr.mode =
-                               S_IWUSR | S_IRUGO;
+                               0644;
                        st->iio_attr[cnt].dev_attr.show =
                                ad7280_show_balance_sw;
                        st->iio_attr[cnt].dev_attr.store =
@@ -577,7 +577,7 @@ static int ad7280_attr_init(struct ad7280_state *st)
                                AD7280A_DEVADDR(dev) << 8 |
                                (AD7280A_CB1_TIMER + ch);
                        st->iio_attr[cnt].dev_attr.attr.mode =
-                               S_IWUSR | S_IRUGO;
+                               0644;
                        st->iio_attr[cnt].dev_attr.show =
                                ad7280_show_balance_timer;
                        st->iio_attr[cnt].dev_attr.store =
@@ -746,26 +746,26 @@ out:
 
 static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
                in_voltage-voltage_thresh_low_value,
-               S_IRUGO | S_IWUSR,
+               0644,
                ad7280_read_channel_config,
                ad7280_write_channel_config,
                AD7280A_CELL_UNDERVOLTAGE);
 
 static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
                in_voltage-voltage_thresh_high_value,
-               S_IRUGO | S_IWUSR,
+               0644,
                ad7280_read_channel_config,
                ad7280_write_channel_config,
                AD7280A_CELL_OVERVOLTAGE);
 
 static IIO_DEVICE_ATTR(in_temp_thresh_low_value,
-               S_IRUGO | S_IWUSR,
+               0644,
                ad7280_read_channel_config,
                ad7280_write_channel_config,
                AD7280A_AUX_ADC_UNDERVOLTAGE);
 
 static IIO_DEVICE_ATTR(in_temp_thresh_high_value,
-               S_IRUGO | S_IWUSR,
+               0644,
                ad7280_read_channel_config,
                ad7280_write_channel_config,
                AD7280A_AUX_ADC_OVERVOLTAGE);