]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
hwmon: (max6697) fix coccinelle warnings
authorFengguang Wu <fengguang.wu@intel.com>
Wed, 18 Sep 2013 03:54:12 +0000 (20:54 -0700)
committerGuenter Roeck <linux@roeck-us.net>
Fri, 18 Oct 2013 16:11:59 +0000 (09:11 -0700)
drivers/hwmon/max6697.c:649:1-3: WARNING: PTR_RET can be used

 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: coccinelle/api/ptr_ret.cocci

CC: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/max6697.c

index 0af910a479abfe90f1ec881d9454e996bf1dddf4..7fd3eaf817f4bffe48267887032b1fa15c81847c 100644 (file)
@@ -646,10 +646,7 @@ static int max6697_probe(struct i2c_client *client,
        hwmon_dev = devm_hwmon_device_register_with_groups(dev, client->name,
                                                           data,
                                                           max6697_groups);
-       if (IS_ERR(hwmon_dev))
-               return PTR_ERR(hwmon_dev);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(hwmon_dev);
 }
 
 static const struct i2c_device_id max6697_id[] = {