]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
cpuidle: check dev before usage in cpuidle_use_deepest_state()
authorLi, Fei <fei.li@intel.com>
Thu, 27 Apr 2017 01:47:25 +0000 (01:47 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 1 May 2017 21:17:20 +0000 (23:17 +0200)
In case of there is no cpuidle devices registered, dev will be null, and
panic will be triggered like below;
In this patch, add checking of dev before usage, like that done in
cpuidle_idle_call.

Panic without fix:
[  184.961328] BUG: unable to handle kernel NULL pointer dereference at
  (null)
[  184.961328] IP: cpuidle_use_deepest_state+0x30/0x60
...
[  184.961328]  play_idle+0x8d/0x210
[  184.961328]  ? __schedule+0x359/0x8e0
[  184.961328]  ? _raw_spin_unlock_irqrestore+0x28/0x50
[  184.961328]  ? kthread_queue_delayed_work+0x41/0x80
[  184.961328]  clamp_idle_injection_func+0x64/0x1e0

Fixes: bb8313b603eb8 (cpuidle: Allow enforcing deepest idle state selection)
Signed-off-by: Li, Fei <fei.li@intel.com>
Tested-by: Shi, Feng <fengx.shi@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: 4.10+ <stable@vger.kernel.org> # 4.10+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpuidle/cpuidle.c

index 548b90be76854850bc4a0aec6863ca898fe1a941..2706be7ed3340fe41ad174d75dc27a9e010e4412 100644 (file)
@@ -111,7 +111,8 @@ void cpuidle_use_deepest_state(bool enable)
 
        preempt_disable();
        dev = cpuidle_get_device();
-       dev->use_deepest_state = enable;
+       if (dev)
+               dev->use_deepest_state = enable;
        preempt_enable();
 }